fix(binder): fix external location table list check end with delimiter '/' #17890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Docker Image for PR
|
Member
Author
|
This PR waiting for opendal to handle with list local fs file return empty instead of error. |
Member
Author
bohutang
added
ci-cloud
Contributor
Docker Image for PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
When creating external location tables, Databend checks list privileges during binding.
AWS S3 Express requires paths to end with a delimiter (/), otherwise it fails:
This PR adds a
/to the end of check keys, maintaining compatibility with the existing implementation.Tests
Type of change
This change is